ref(async-inserts): allow async inserts as an option #5955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MeredithAnya
commented
May 22, 2024
MeredithAnya
commented
May 22, 2024
untitaker
reviewed
May 23, 2024
| query_params.push_str("load_balancing=in_order&insert_distributed_sync=1"); | ||
|
|
||
| let async_inserts_allowed = get_str_config("async_inserts_allowed").ok().flatten(); | ||
| if async_inserts && async_inserts_allowed == Some(1.to_string()) { |
There was a problem hiding this comment.
Suggested change
| if async_inserts && async_inserts_allowed == Some(1.to_string()) { | |
| if async_inserts && async_inserts_allowed == Some("1") { |
that should also work
There was a problem hiding this comment.
I think I still need to_string() because it was expecting String instead of &str
MeredithAnya
force-pushed
the
meredith/5-21-24
branch
from
d0fb453
to
98cfa8e
Compare
untitaker
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are going to try out async inserts for specific S4S clusters to test it out and see the impacts of enabling it. This adds a cli arg that we can use to target consumers for specific clusters (e.g. https://github.com/getsentry/ops/pull/10687). I'm also adding a runtime config flag
async_inserts_allowedso that we can turn it on and off as we test without having to put up code changes.When (and if) we move forward to enabling this on more clusters, we won't be able to use the runtime config in the same way since it would turn things on and off across the board, so this is really for testing purposes at this moment
Pre-req for https://github.com/getsentry/ops/pull/10687