cleanup(inc-723): always run LowCardinalityProcessor, remove ConditionSimpllifier #5820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikhars
approved these changes
Apr 25, 2024
Zylphrex
reviewed
Apr 26, 2024
| ) | ||
| == 0 | ||
| ): | ||
| if state.get_int_config("use.low.cardinality.processor", 1) == 0: |
There was a problem hiding this comment.
Enabling this by default caused some test failures last time that blocked sentry master, have we checked it won't happen again?
There was a problem hiding this comment.
The processor now works differently, the ifNull(col, "") is removed, instead it casts to a Nullable(String). I ran some of the failed tests locally with the new processor and they passed
Zylphrex
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the
USE_CARDINALITY_CASTERsetting is no longer necessary. it was shipped to fix CI urgently. The real fix is in now.The
ConditionSimplifierProcessoris also unnecessary now. We can remove it from the codebase and tests. TheLowCardinalityProcessortakes care of this bug by itself