Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit a metric when replacements are skipped #5809

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Conversation

xurui-c
Copy link
Member

@xurui-c xurui-c commented Apr 23, 2024

https://getsentry.atlassian.net/browse/SNS-2710

This PR emits a DataDog metric when we skip replacements for orgs/projects within the errors-replacements pipeline. After this PR is deployed, I will then create a graph on the Datadog replacements dashboard

@xurui-c xurui-c changed the title emit metrics Emit a metric when replacements are skipped Apr 23, 2024
@xurui-c xurui-c marked this pull request as ready for review April 23, 2024 21:44
@xurui-c xurui-c requested a review from a team as a code owner April 23, 2024 21:44
@xurui-c xurui-c requested a review from onewland April 23, 2024 21:45
snuba/replacers/errors_replacer.py Outdated Show resolved Hide resolved
@xurui-c xurui-c requested a review from onewland April 23, 2024 21:48
@xurui-c xurui-c merged commit cd1c90f into master Apr 23, 2024
25 of 29 checks passed
@xurui-c xurui-c deleted the rachel/replacementsMetrics branch April 23, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants