New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(22.8) don't use ifnull for cardinality casting #5807

Merged

evanh merged 2 commits into master from volo/hotfix/fix_cardinality_processor

Apr 23, 2024

Member

volokluev commented Apr 23, 2024

ifNull function here doesn't do us any good because sentry actually expects null back, cast to a Nullable(string) instead


          don't use ifnull for cardinality casting

10afa9d

volokluev requested a review from a team as a code owner

April 23, 2024 00:00


          test with a non-low-cardinality column

f75d7f2

evanh approved these changes

View reviewed changes

evanh merged commit 9f421e2 into master

29 checks passed

evanh deleted the volo/hotfix/fix_cardinality_processor branch

April 23, 2024 14:18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet