Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(self-hosted): Fix type of retention days #5591

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

untitaker
Copy link
Member

No description provided.

@untitaker untitaker requested a review from a team as a code owner February 27, 2024 20:26
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 89.94%. Comparing base (ada1f34) to head (1f8c37a).
Report is 7 commits behind head on master.

Files Patch % Lines
snuba/settings/settings_self_hosted.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5591   +/-   ##
=======================================
  Coverage   89.93%   89.94%           
=======================================
  Files         897      900    +3     
  Lines       43538    43624   +86     
  Branches      288      288           
=======================================
+ Hits        39155    39236   +81     
- Misses       4341     4346    +5     
  Partials       42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hubertdeng123 hubertdeng123 merged commit 7e285c2 into master Feb 28, 2024
31 of 32 checks passed
@hubertdeng123 hubertdeng123 deleted the fix/snuba-retention-days branch February 28, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants