Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change DefaultNoneColumnMapper to use a normal set #3580

Merged
merged 3 commits into from
Jan 11, 2023

Commits on Jan 9, 2023

  1. fix: Change DefaultNoneColumnMapper to use a normal set

    Dataset configuration doesn't support complex objects for registered classes
    like this. In order for the discover entity to be migration to YAML, there needs
    to be a different way to initialize this class that can be encoded in YAML.
    
    This mapper is checking if a column name exists in the ColumnSet. That check
    compares against the flattened column name stored in the ColumnSet. This can be
    achieved by comparing to a normal set instead of a ColumnSet.
    evanh committed Jan 9, 2023
    Configuration menu
    Copy the full SHA
    b62463c View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2023

  1. Configuration menu
    Copy the full SHA
    50d79ce View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2023

  1. fix entity

    evanh committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    580d297 View commit details
    Browse the repository at this point in the history