fix(DC): Bring EntityContainsColumnsValidator back to config entities #3540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 92.20% // Head: 92.17% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3540 +/- ##
==========================================
- Coverage 92.20% 92.17% -0.03%
==========================================
Files 723 720 -3
Lines 33832 33779 -53
==========================================
- Hits 31195 31137 -58
- Misses 2637 2642 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
added 2 commits
December 16, 2022 16:33
rahul-kumar-saini
approved these changes
Dec 19, 2022
| @@ -61,24 +61,30 @@ def _config_matches_python_definition( | |||
| self, config_path: str, entity: Type[Entity], entity_key: EntityKey | |||
| ) -> None: | |||
| config_entity = build_entity_from_config(config_path) | |||
| print(config_entity.get_validators()) | |||
| EntityColumnSet(self.columns), ColumnValidationMode.DO_NOTHING | ||
| ) | ||
| ] | ||
| return [] |
volokluev
added a commit
that referenced
this pull request
Jan 9, 2023
…#3579) A repeat of #3540 but fixing two bad lines of code which should not have been merged Due to a bug in our testing, we have not been including the EntityContainsColumnsValidator in the entities built with config. Having a place where the built in validators are defined makes it easier to auto-convert entities as we can skip the default ones in the config. ### Blast Radius This will affect only config entities (metrics) and this is re-introducing a columns validator which is turned off. This is essentially a no-op.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a bug in our testing, we have not been including the EntityContainsColumnsValidator in the entities built with config. Having a place where the built in validators are defined makes it easier to auto-convert entities as we can skip the default ones in the config.
Blast Radius
This will affect only config entities (metrics) and this is re-introducing a columns validator which is turned off. This is essentially a no-op.