Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Remove redundant filter #3520

Merged
merged 1 commit into from
Dec 14, 2022
Merged

ref: Remove redundant filter #3520

merged 1 commit into from
Dec 14, 2022

Conversation

lynnagara
Copy link
Member

No description provided.

@lynnagara lynnagara requested a review from a team as a code owner December 14, 2022 19:09
@codecov-commenter
Copy link

codecov-commenter commented Dec 14, 2022

Codecov Report

Base: 91.32% // Head: 27.44% // Decreases project coverage by -63.87% ⚠️

Coverage data is based on head (95f7ea7) compared to base (9683fc1).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #3520       +/-   ##
===========================================
- Coverage   91.32%   27.44%   -63.88%     
===========================================
  Files         720      675       -45     
  Lines       33604    32132     -1472     
===========================================
- Hits        30688     8819    -21869     
- Misses       2916    23313    +20397     
Impacted Files Coverage Δ
snuba/datasets/message_filters.py 75.00% <ø> (-20.35%) ⬇️
tests/base.py 0.00% <0.00%> (-100.00%) ⬇️
tests/helpers.py 0.00% <0.00%> (-100.00%) ⬇️
tests/conftest.py 0.00% <0.00%> (-100.00%) ⬇️
tests/fixtures.py 0.00% <0.00%> (-100.00%) ⬇️
tests/test_cli.py 0.00% <0.00%> (-100.00%) ⬇️
tests/test_util.py 0.00% <0.00%> (-100.00%) ⬇️
snuba/admin/user.py 0.00% <0.00%> (-100.00%) ⬇️
tests/assertions.py 0.00% <0.00%> (-100.00%) ⬇️
tests/test_redis.py 0.00% <0.00%> (-100.00%) ⬇️
... and 609 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lynnagara lynnagara merged commit 7a8b485 into master Dec 14, 2022
@lynnagara lynnagara deleted the remove-pointless-filter branch December 14, 2022 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants