Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix coverage paths #3499

Merged
merged 1 commit into from
Dec 14, 2022
Merged

fix coverage paths #3499

merged 1 commit into from
Dec 14, 2022

Conversation

dbanda
Copy link
Contributor

@dbanda dbanda commented Dec 11, 2022

Some of the tests were overwriting each others coverage files. This fix renames the coverage paths to give each tests its own coverage file.

@codecov-commenter
Copy link

Codecov Report

Base: 91.14% // Head: 21.68% // Decreases project coverage by -69.46% ⚠️

Coverage data is based on head (25581da) compared to base (9b91174).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #3499       +/-   ##
===========================================
- Coverage   91.14%   21.68%   -69.47%     
===========================================
  Files         717      673       -44     
  Lines       33371    32124     -1247     
===========================================
- Hits        30415     6965    -23450     
- Misses       2956    25159    +22203     
Impacted Files Coverage Δ
tests/base.py 0.00% <0.00%> (-100.00%) ⬇️
tests/helpers.py 0.00% <0.00%> (-100.00%) ⬇️
tests/conftest.py 0.00% <0.00%> (-100.00%) ⬇️
tests/fixtures.py 0.00% <0.00%> (-100.00%) ⬇️
tests/test_cli.py 0.00% <0.00%> (-100.00%) ⬇️
tests/test_util.py 0.00% <0.00%> (-100.00%) ⬇️
snuba/admin/user.py 0.00% <0.00%> (-100.00%) ⬇️
tests/assertions.py 0.00% <0.00%> (-100.00%) ⬇️
tests/test_redis.py 0.00% <0.00%> (-100.00%) ⬇️
tests/test_writer.py 0.00% <0.00%> (-100.00%) ⬇️
... and 644 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dbanda dbanda changed the title fix coverage fix coverage paths Dec 13, 2022
@dbanda dbanda marked this pull request as ready for review December 13, 2022 23:19
Copy link
Member

@lynnagara lynnagara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lynnagara
Copy link
Member

Is this why we have reports like the one posted above in this PR? (project coverage changed by -69.46%)

@dbanda
Copy link
Contributor Author

dbanda commented Dec 14, 2022

Is this why we have reports like the one posted above in this PR? (project coverage changed by -69.46%)

That's one of the reasons. But the bigger issue is that sometimes codecov uploads fail. They are pretty unreliable. But by default codecov will not return a fail code if that happens. you have to specify that behavior with the -Z flag.

@dbanda dbanda merged commit eddd383 into master Dec 14, 2022
@dbanda dbanda deleted the dbanda/fix/codecov branch December 14, 2022 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants