feat(DC): Discover Storage as a Config #3480
Conversation
Codecov ReportBase: 91.67% // Head: 91.67% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3480 +/- ##
=======================================
Coverage 91.67% 91.67%
=======================================
Files 715 715
Lines 33466 33467 +1
=======================================
+ Hits 30679 30680 +1
Misses 2787 2787
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
| column_name: tags | ||
| - processor: UUIDColumnProcessor | ||
| args: | ||
| columns: !!set |
There was a problem hiding this comment.
It's the yaml syntax for a set. I was confused at first too but that's just how you define a set in yaml 😅
There was a problem hiding this comment.
Lol that is bizarre but good to know it's supported. I think we had type issues with that before.
| column_name: tags | ||
| - processor: UUIDColumnProcessor | ||
| args: | ||
| columns: !!set |
There was a problem hiding this comment.
Lol that is bizarre but good to know it's supported. I think we had type issues with that before.
Overview
Changes
get_storage()with a discover storage key will return the storage built from config instead of the hardcoded versionTesting Notes
python3 scripts/pystorage_2_yaml.py discover discover.yamlcolumnsin schema, format yaml file with Prettierpython3 scripts/check_yaml_against_code.py discover discover.yamltests/datasets/configuration/test_storage_loader.py