Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(slicing): Add mega-cluster and basic consumer setup #3433

Merged
merged 7 commits into from
Jan 4, 2023

Conversation

ayirr7
Copy link
Member

@ayirr7 ayirr7 commented Nov 22, 2022

This PR is the first step towards furthering the docs for slicing (https://getsentry.atlassian.net/browse/SNS-1893)

Next steps are:

  • As sliced scheduler and executor work are completed, fill in the section about subscriptions
  • Potentially add a diagram for the mega cluster
  • Explain the end to end for slicing, slicing boundaries

@ayirr7 ayirr7 requested a review from a team as a code owner November 22, 2022 18:39
@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2022

Codecov Report

Base: 91.71% // Head: 92.22% // Increases project coverage by +0.51% 🎉

Coverage data is based on head (15a7954) compared to base (6917371).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3433      +/-   ##
==========================================
+ Coverage   91.71%   92.22%   +0.51%     
==========================================
  Files         724      724              
  Lines       33782    33782              
==========================================
+ Hits        30983    31156     +173     
+ Misses       2799     2626     -173     
Impacted Files Coverage Δ
snuba/datasets/storages/factory.py 95.95% <0.00%> (+2.02%) ⬆️
snuba/datasets/slicing.py 88.88% <0.00%> (+11.11%) ⬆️
snuba/cli/__init__.py 86.36% <0.00%> (+18.18%) ⬆️
snuba/utils/streams/metrics_adapter.py 83.33% <0.00%> (+83.33%) ⬆️
snuba/consumers/consumer_builder.py 92.59% <0.00%> (+92.59%) ⬆️
snuba/cli/consumer.py 94.44% <0.00%> (+94.44%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@onewland onewland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this clean-up!

@ayirr7 ayirr7 merged commit f5d6e26 into master Jan 4, 2023
@ayirr7 ayirr7 deleted the improve-slicing-docs branch January 4, 2023 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants