Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explain the ordering flags in MIGRATIONS.md #3365

Merged
merged 3 commits into from
Nov 10, 2022
Merged

Explain the ordering flags in MIGRATIONS.md #3365

merged 3 commits into from
Nov 10, 2022

Conversation

dbanda
Copy link
Contributor

@dbanda dbanda commented Nov 9, 2022

No description provided.

@dbanda dbanda requested a review from a team as a code owner November 9, 2022 20:24
evanh
evanh approved these changes Nov 9, 2022
View reviewed changes
Copy link
Member

@evanh evanh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some micro-changes.

MIGRATIONS.md Outdated Show resolved Hide resolved
@dbanda @evanh
Update MIGRATIONS.md
76ce1ad 
Co-authored-by: Evan Hicks <[email protected]>
@dbanda dbanda enabled auto-merge (squash) November 10, 2022 01:00
@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2022 •
edited
Loading

Codecov Report

Base: 90.76% // Head: 27.56% // Decreases project coverage by -63.19% ⚠️

Coverage data is based on head (36ebca3) compared to base (8f23e9f).
Patch coverage: 0.00% of modified lines in pull request are covered.

❗ Current head 36ebca3 differs from pull request most recent head 76ce1ad. Consider uploading reports for the commit 76ce1ad to get more accurate results

Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #3365       +/-   ##
===========================================
- Coverage   90.76%   27.56%   -63.20%     
===========================================
  Files         703      662       -41     
  Lines       32403    31113     -1290     
===========================================
- Hits        29410     8577    -20833     
- Misses       2993    22536    +19543
Impacted Files Coverage Δ
snuba/admin/clickhouse/querylog.py 0.00% <0.00%> (-100.00%) ⬇️
snuba/admin/migrations_policies.py 0.00% <0.00%> (-100.00%) ⬇️
tests/base.py 0.00% <0.00%> (-100.00%) ⬇️
tests/helpers.py 0.00% <0.00%> (-100.00%) ⬇️
tests/conftest.py 0.00% <0.00%> (-100.00%) ⬇️
tests/fixtures.py 0.00% <0.00%> (-100.00%) ⬇️
tests/test_cli.py 0.00% <0.00%> (-100.00%) ⬇️
tests/test_util.py 0.00% <0.00%> (-100.00%) ⬇️
snuba/admin/user.py 0.00% <0.00%> (-100.00%) ⬇️
tests/assertions.py 0.00% <0.00%> (-100.00%) ⬇️
... and 592 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dbanda dbanda merged commit 866750f into master Nov 10, 2022
@dbanda dbanda deleted the dbanda-update-migrations-doc branch November 10, 2022 01:20
dbanda added a commit that referenced this pull request Nov 10, 2022
@dbanda @evanh
Explain the ordering flags in MIGRATIONS.md (#3365)
00b512b 
* Update MIGRATIONS.md

* Update MIGRATIONS.md

* Update MIGRATIONS.md

Co-authored-by: Evan Hicks <[email protected]>

Co-authored-by: Evan Hicks <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evanh evanh evanh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dbanda @codecov-commenter @evanh