fix(rate_limit): Set explicit TTL for set of open requests [SNS-1864] #3362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
step to repro leak: 1) add set items, but do not explicitly remove them. possible by killing processes while a query is running 2) stop processing requests for a particular bucket. possible by deleting a project that receives queries. we maintain sets of open requests per-project, using https://github.com/getsentry/snuba/blob/a9ef6c56594246d0182a2b07728d1446a10e881b/snuba/query/processors/logical/object_id_rate_limiter.py#L19 without 1), we would be deleting set items explicitly on context manager exit. Empty sets are equivalent to deleted keys in Redis. without 2), we would have an extremely limited number of possible values for `bucket`, so the issue is practically nonexistent. but since we maintain sets per "object id" it's possible for a user to produce new redis keys without ttl by creating/deleting projects without an explicit TTL, we will be leaking tiny sets over time.
untitaker
changed the title
Codecov ReportBase: 90.75% // Head: 90.75% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3362 +/- ##
=======================================
Coverage 90.75% 90.75%
=======================================
Files 704 704
Lines 32335 32344 +9
=======================================
+ Hits 29345 29355 +10
+ Misses 2990 2989 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
evanh
approved these changes
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
step to repro leak:
processes while a query is running
deleting a project that receives queries. we maintain sets of open
requests per-project, using
snuba/snuba/query/processors/logical/object_id_rate_limiter.py
Line 19 in a9ef6c5
without 1), we would be deleting set items explicitly on context manager
exit. Empty sets are equivalent to deleted keys in Redis.
without 2), we would have an extremely limited number of possible values
for
bucket, so the issue is practically nonexistent. but since wemaintain sets per "object id" it's possible for a user to produce new
redis keys without ttl by creating/deleting projects
without an explicit TTL, we will be leaking tiny sets over time.