Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(logging): Incorrect Snuba init instrumentation #3361

Merged
merged 2 commits into from
Nov 9, 2022

Conversation

rahul-kumar-saini
Copy link
Contributor

Overview

  • Changes in Explicitly initialize snuba take 3 #3347 broke the Snuba initialization transaction
  • Attempting to fix by starting the transaction when the relevant module(s) for the command is loaded
  • Works locally

@rahul-kumar-saini rahul-kumar-saini requested a review from a team as a code owner November 8, 2022 23:45
@rahul-kumar-saini rahul-kumar-saini enabled auto-merge (squash) November 8, 2022 23:48
@codecov-commenter
Copy link

Codecov Report

Base: 91.28% // Head: 91.28% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (23503fd) compared to base (245ee62).
Patch coverage: 80.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3361      +/-   ##
==========================================
- Coverage   91.28%   91.28%   -0.01%     
==========================================
  Files         704      704              
  Lines       32336    32335       -1     
==========================================
- Hits        29518    29517       -1     
  Misses       2818     2818              
Impacted Files Coverage Δ
snuba/cli/__init__.py 86.36% <80.00%> (-0.31%) ⬇️
snuba/state/cache/redis/backend.py 94.78% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rahul-kumar-saini rahul-kumar-saini merged commit 578f573 into master Nov 9, 2022
@rahul-kumar-saini rahul-kumar-saini deleted the rahul/fix/snuba-init-transaction branch November 9, 2022 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants