Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(mdc): Remove dead code #3252

Merged
merged 1 commit into from
Oct 13, 2022
Merged

ref(mdc): Remove dead code #3252

merged 1 commit into from
Oct 13, 2022

Conversation

lynnagara
Copy link
Member

No description provided.

@lynnagara lynnagara requested a review from a team as a code owner October 13, 2022 19:01
@volokluev
Copy link
Member

volokluev commented Oct 13, 2022 •
edited
Loading

This is because sessions subscriptions are dead?

@lynnagara
Copy link
Member Author

This is because sessions subscriptions are dead?

Oh no. This is just because I don't see _PARENT_SUBSCRIPTION_CLASS_MAPPING being used anywhere in our codebase - assume it's dead code.

@lynnagara lynnagara merged commit 8aa285d into master Oct 13, 2022
@lynnagara lynnagara deleted the entity-subscription branch October 13, 2022 23:13
enochtangg pushed a commit that referenced this pull request Oct 17, 2022
@lynnagara @enochtangg
ref(mdc): Remove dead code (#3252)
7b8c1a5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbanda dbanda dbanda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lynnagara @volokluev @dbanda