Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Small settings cleanup #3251

Merged
merged 1 commit into from
Oct 14, 2022
Merged

ref: Small settings cleanup #3251

merged 1 commit into from
Oct 14, 2022

Conversation

lynnagara
Copy link
Member

We no longer emit these metrics

We no longer emit these metrics
@lynnagara lynnagara requested a review from a team as a code owner October 13, 2022 18:13
@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2022

Codecov Report

Base: 92.30% // Head: 92.31% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (ae5bb9c) compared to base (a77edea).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3251      +/-   ##
==========================================
+ Coverage   92.30%   92.31%   +0.01%     
==========================================
  Files         697      697              
  Lines       31630    31655      +25     
==========================================
+ Hits        29195    29222      +27     
+ Misses       2435     2433       -2     
Impacted Files Coverage Δ
snuba/settings/__init__.py 95.33% <ø> (-0.07%) ⬇️
snuba/datasets/entities/generic_metrics.py 95.34% <0.00%> (-2.33%) ⬇️
snuba/subscriptions/executor_consumer.py 91.84% <0.00%> (ø)
tests/admin/clickhouse_migrations/test_api.py 100.00% <0.00%> (ø)
snuba/admin/views.py 76.84% <0.00%> (+0.55%) ⬆️
snuba/datasets/entity_subscriptions/factory.py 75.55% <0.00%> (+1.08%) ⬆️
snuba/datasets/pluggable_entity.py 89.65% <0.00%> (+1.72%) ⬆️
snuba/datasets/entities/factory.py 91.89% <0.00%> (+2.55%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lynnagara lynnagara merged commit 7e73c1f into master Oct 14, 2022
@lynnagara lynnagara deleted the remove-sampling-rates branch October 14, 2022 17:48
enochtangg pushed a commit that referenced this pull request Oct 17, 2022
We no longer emit these metrics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants