Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(EntityKey): Rename GROUPEDMESSAGES to GROUPEDMESSAGE #3123

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

rahul-kumar-saini
Copy link
Contributor

Overview

🤮 EntityKey.GROUPEDMESSAGES 💩

😎 EntityKey.GROUPEDMESSAGE 🥇

Notes

@rahul-kumar-saini rahul-kumar-saini marked this pull request as ready for review September 6, 2022 20:48
@rahul-kumar-saini rahul-kumar-saini requested a review from a team as a code owner September 6, 2022 20:48
@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2022

Codecov Report

Base: 93.09% // Head: 92.84% // Decreases project coverage by -0.24% ⚠️

Coverage data is based on head (995396a) compared to base (b7287f5).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3123      +/-   ##
==========================================
- Coverage   93.09%   92.84%   -0.25%     
==========================================
  Files         667      667              
  Lines       30717    30717              
==========================================
- Hits        28595    28520      -75     
- Misses       2122     2197      +75     
Impacted Files Coverage Δ
snuba/datasets/entities/events.py 95.94% <ø> (ø)
snuba/datasets/entities/factory.py 89.18% <ø> (ø)
tests/datasets/test_entity_factory.py 100.00% <ø> (ø)
tests/pipeline/test_composite_planner.py 100.00% <ø> (ø)
tests/query/formatters/test_query.py 100.00% <ø> (ø)
tests/query/joins/equivalence_schema.py 95.65% <ø> (ø)
tests/query/joins/join_structures.py 100.00% <ø> (ø)
tests/query/snql/test_invalid_queries.py 100.00% <ø> (ø)
tests/query/snql/test_query.py 100.00% <ø> (ø)
tests/query/snql/test_snql_anonymizer.py 100.00% <ø> (ø)
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rahul-kumar-saini rahul-kumar-saini merged commit 3d1084f into master Sep 6, 2022
@rahul-kumar-saini rahul-kumar-saini deleted the rahul/ref/groupedmessages-entity-key branch September 6, 2022 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants