Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(upgrade): Similar query processors for both error storages #3105

Merged
merged 2 commits into from
Sep 12, 2022

Conversation

nikhars
Copy link
Member

@nikhars nikhars commented Aug 31, 2022

In order to map errors dataset to the tiger cluster, we need to make the query processors be the same for errors and errors_v2. That means adding tuple_unaliaser to the errors dataset.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@nikhars nikhars requested a review from a team as a code owner August 31, 2022 18:37
@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2022

Codecov Report

Base: 92.75% // Head: 93.09% // Increases project coverage by +0.33% 🎉

Coverage data is based on head (6708b59) compared to base (1d53011).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3105      +/-   ##
==========================================
+ Coverage   92.75%   93.09%   +0.33%     
==========================================
  Files         673      673              
  Lines       30888    30889       +1     
==========================================
+ Hits        28650    28755     +105     
+ Misses       2238     2134     -104     
Impacted Files Coverage Δ
snuba/datasets/storages/errors_common.py 100.00% <100.00%> (ø)
snuba/clusters/cluster.py 96.55% <0.00%> (+0.68%) ⬆️
snuba/migrations/table_engines.py 98.87% <0.00%> (+3.37%) ⬆️
...ba/snuba_migrations/events/0014_backfill_errors.py 96.36% <0.00%> (+3.63%) ⬆️
tests/migrations/test_runner_individual.py 93.40% <0.00%> (+40.65%) ⬆️
...ts/0010_groupedmessages_onpremise_compatibility.py 100.00% <0.00%> (+48.88%) ⬆️
...nsactions_onpremise_fix_orderby_and_partitionby.py 84.00% <0.00%> (+52.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nikhars nikhars merged commit ede6c19 into master Sep 12, 2022
@nikhars nikhars deleted the feat/rollback_errors_query_processors branch September 12, 2022 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants