Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: use internal pypi for prebuilt packages #3100

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

asottile-sentry
Copy link
Member

@asottile-sentry asottile-sentry commented Aug 31, 2022

this changes from using public pypi to using our "internal" (but publicly accessible) pypi

the main advantage is on the 4 supported platforms (linux, macos) x (x86_64, arm64) all python dependencies are prebuilt and will not need to be built from source

pypi packages are sourced from https://github.com/getsentry/pypi

@codecov-commenter
Copy link

Codecov Report

Base: 93.08% // Head: 93.02% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (ba48b0f) compared to base (f28d52f).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3100      +/-   ##
==========================================
- Coverage   93.08%   93.02%   -0.06%     
==========================================
  Files         662      662              
  Lines       30483    30483              
==========================================
- Hits        28374    28356      -18     
- Misses       2109     2127      +18     
Impacted Files Coverage Δ
setup.py 0.00% <0.00%> (ø)
snuba/settings/settings_distributed.py 0.00% <0.00%> (-100.00%) ⬇️
snuba/settings/settings_test_distributed.py 0.00% <0.00%> (-100.00%) ⬇️
...ts/0010_groupedmessages_onpremise_compatibility.py 95.55% <0.00%> (-4.45%) ⬇️
snuba/migrations/table_engines.py 95.50% <0.00%> (-3.38%) ⬇️
snuba/optimize.py 89.10% <0.00%> (-2.98%) ⬇️
...nsactions_onpremise_fix_orderby_and_partitionby.py 81.33% <0.00%> (-2.67%) ⬇️
tests/migrations/test_runner_individual.py 91.20% <0.00%> (-2.20%) ⬇️
snuba/clusters/cluster.py 95.17% <0.00%> (-1.38%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

black==22.6.0
blinker==1.5
click==8.1.3
clickhouse-driver==0.2.4
confluent-kafka==1.8.2
Copy link
Member Author

@asottile-sentry asottile-sentry Aug 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to additionally update confluent-kafka and arroyo because I didn't build confluent-kafka<1.9.2 for pypi. previous versions have various trouble building on the 4 supported platform/arch 2-ples

this is the version that's already live in sentry

@@ -1,16 +1,6 @@
ARG PYTHON_VERSION=3.8.13
FROM python:${PYTHON_VERSION}-slim-bullseye AS application

# these are required all the way through, and removing them will cause bad things
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love me a "bad things" comment -- this shouldn't matter because everything prebuilt has its deps built in in accordance with manylinux

@asottile-sentry asottile-sentry marked this pull request as ready for review September 1, 2022 13:10
@asottile-sentry asottile-sentry requested a review from a team as a code owner September 1, 2022 13:10
Copy link
Member

@evanh evanh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ping the sns on-call when you deploy this, just so we can watch the kafka changes.

@asottile-sentry
Copy link
Member Author

Please ping the sns on-call when you deploy this, just so we can watch the kafka changes.

sounds good -- I plan to do this after the holidays !

@asottile-sentry asottile-sentry merged commit f8107ac into master Sep 6, 2022
@asottile-sentry asottile-sentry deleted the asottile-index-url branch September 6, 2022 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants