-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref: use internal pypi for prebuilt packages #3100
Conversation
Codecov ReportBase: 93.08% // Head: 93.02% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3100 +/- ##
==========================================
- Coverage 93.08% 93.02% -0.06%
==========================================
Files 662 662
Lines 30483 30483
==========================================
- Hits 28374 28356 -18
- Misses 2109 2127 +18
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ba48b0f
to
b4b463c
Compare
b4b463c
to
6e85525
Compare
black==22.6.0 | ||
blinker==1.5 | ||
click==8.1.3 | ||
clickhouse-driver==0.2.4 | ||
confluent-kafka==1.8.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to additionally update confluent-kafka and arroyo because I didn't build confluent-kafka<1.9.2 for pypi. previous versions have various trouble building on the 4 supported platform/arch 2-ples
this is the version that's already live in sentry
@@ -1,16 +1,6 @@ | |||
ARG PYTHON_VERSION=3.8.13 | |||
FROM python:${PYTHON_VERSION}-slim-bullseye AS application | |||
|
|||
# these are required all the way through, and removing them will cause bad things |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
love me a "bad things" comment -- this shouldn't matter because everything prebuilt has its deps built in in accordance with manylinux
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please ping the sns on-call when you deploy this, just so we can watch the kafka changes.
sounds good -- I plan to do this after the holidays ! |
this changes from using public pypi to using our "internal" (but publicly accessible) pypi
the main advantage is on the 4 supported platforms (linux, macos) x (x86_64, arm64) all python dependencies are prebuilt and will not need to be built from source
pypi packages are sourced from https://github.com/getsentry/pypi