Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config(mep): add table rate limit and tuple unaliaser to sets/distributions #3019

Merged
merged 1 commit into from
Aug 3, 2022

Conversation

onewland
Copy link
Contributor

@onewland onewland commented Aug 2, 2022

  • add the TableRateLimit and TupleUnaliaser on generic_metrics storages
  • remove the broken ArrayJoinKeyValueOptimizer (it didn't work because tags has two value columns, neither named value)

@onewland onewland requested a review from a team as a code owner August 2, 2022 23:29
@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2022

Codecov Report

Merging #3019 (eb005e6) into master (44f60a2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3019   +/-   ##
=======================================
  Coverage   93.02%   93.02%           
=======================================
  Files         646      646           
  Lines       29651    29653    +2     
=======================================
+ Hits        27582    27584    +2     
  Misses       2069     2069           
Impacted Files Coverage Δ
snuba/datasets/storages/generic_metrics.py 96.55% <100.00%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44f60a2...eb005e6. Read the comment docs.

@onewland onewland merged commit 73d4ee6 into master Aug 3, 2022
@onewland onewland deleted the add-table-rate-limiter-tuple-unaliaser branch August 3, 2022 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants