Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rollout): Make transaction query processors same #3006

Merged
merged 1 commit into from
Aug 2, 2022

Conversation

nikhars
Copy link
Member

@nikhars nikhars commented Jul 29, 2022

In order to map the transactions dataset to the transactions-tiger
cluster and make it seamless, have the same set of query processors
run for both.

Verified locally that applying the query processor on 20.7 cluster
does not have a negative impact

In order to map the transactions dataset to the transactions-tiger
cluster and make it seamless, have the same set of query processors
run for both.

Verified locally that applying the query processor on 20.7 cluster
does not have a negative impact
@nikhars nikhars requested a review from a team as a code owner July 29, 2022 23:10
@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2022

Codecov Report

Merging #3006 (2c5f514) into master (a30a63e) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3006      +/-   ##
==========================================
- Coverage   93.00%   92.99%   -0.01%     
==========================================
  Files         645      645              
  Lines       29602    29628      +26     
==========================================
+ Hits        27532    27554      +22     
- Misses       2070     2074       +4     
Impacted Files Coverage Δ
snuba/datasets/storages/transactions_v2.py 100.00% <ø> (ø)
snuba/datasets/storages/transactions_common.py 100.00% <100.00%> (ø)
snuba/admin/clickhouse/system_queries.py 78.00% <0.00%> (-6.62%) ⬇️
snuba/attribution/log.py 85.48% <0.00%> (-1.62%) ⬇️
snuba/utils/metrics/backends/datadog.py 0.00% <0.00%> (ø)
snuba/datasets/transactions_processor.py 91.04% <0.00%> (+0.04%) ⬆️
tests/datasets/test_transaction_processor.py 99.03% <0.00%> (+0.17%) ⬆️
snuba/query/processors/tuple_unaliaser.py 93.87% <0.00%> (+2.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a30a63e...2c5f514. Read the comment docs.

@nikhars nikhars merged commit 8dab58a into master Aug 2, 2022
@nikhars nikhars deleted the rollout/transactions_query_processors branch August 2, 2022 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants