Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mep): add new subscription-related generic-metrics topics #2935

Merged
merged 1 commit into from
Jul 14, 2022

Conversation

onewland
Copy link
Contributor

scheduled-* is needed to deploy the scheduler

*-results will be needed to deploy the executor

@codecov-commenter
Copy link

Codecov Report

Merging #2935 (3eb0703) into master (5d9755c) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2935      +/-   ##
==========================================
- Coverage   92.93%   92.87%   -0.07%     
==========================================
  Files         635      635              
  Lines       29069    29073       +4     
==========================================
- Hits        27016    27002      -14     
- Misses       2053     2071      +18     
Impacted Files Coverage Δ
snuba/settings/validation.py 71.87% <ø> (ø)
snuba/utils/streams/topics.py 100.00% <100.00%> (ø)
snuba/settings/settings_distributed.py 0.00% <0.00%> (-100.00%) ⬇️
snuba/settings/settings_test_distributed.py 0.00% <0.00%> (-100.00%) ⬇️
...ts/0010_groupedmessages_onpremise_compatibility.py 95.55% <0.00%> (-4.45%) ⬇️
snuba/optimize.py 87.50% <0.00%> (-3.75%) ⬇️
snuba/migrations/table_engines.py 95.50% <0.00%> (-3.38%) ⬇️
...nsactions_onpremise_fix_orderby_and_partitionby.py 81.33% <0.00%> (-2.67%) ⬇️
tests/migrations/test_runner_individual.py 91.20% <0.00%> (-2.20%) ⬇️
snuba/clusters/cluster.py 94.92% <0.00%> (-1.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d9755c...3eb0703. Read the comment docs.

@onewland onewland merged commit 3de57bb into master Jul 14, 2022
@onewland onewland deleted the add-new-subscription-related-topics branch July 14, 2022 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants