Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(replays): add replays dataset to dataset factory #2913

Merged
merged 2 commits into from
Jul 8, 2022

Conversation

JoshFerge
Copy link
Member

  • adding here as I noticed its needed for the SnQL UI page, not sure there are any other ramifications I should know about.

@JoshFerge JoshFerge requested a review from a team as a code owner July 7, 2022 14:13
@JoshFerge JoshFerge changed the title feat: add replays dataset to dataset factory feat(replays): add replays dataset to dataset factory Jul 7, 2022
@JoshFerge JoshFerge requested a review from cmanallen July 7, 2022 14:13
Copy link
Member

@evanh evanh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure there are any other ramifications I should know about.

Not that I can think of.

@JoshFerge JoshFerge merged commit a1cdb3f into master Jul 8, 2022
@JoshFerge JoshFerge deleted the jferg/replays-dataset branch July 8, 2022 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants