Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enforce retention_days is int type #2809

Merged
merged 1 commit into from
Jun 14, 2022
Merged

enforce retention_days is int type #2809

merged 1 commit into from
Jun 14, 2022

Conversation

MeredithAnya
Copy link
Member

If the retention_days provided is not an int we will just use the DEFAULT_RETENTION_DAYS. Should fix #2780.

@MeredithAnya MeredithAnya requested a review from a team as a code owner June 13, 2022 19:58
@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2022

Codecov Report

Merging #2809 (7c72124) into master (02dbd05) will decrease coverage by 0.35%.
The diff coverage is 100.00%.

❗ Current head 7c72124 differs from pull request most recent head e4782d1. Consider uploading reports for the commit e4782d1 to get more accurate results

@@            Coverage Diff             @@
##           master    #2809      +/-   ##
==========================================
- Coverage   92.83%   92.47%   -0.36%     
==========================================
  Files         611      612       +1     
  Lines       28639    28662      +23     
==========================================
- Hits        26586    26505      -81     
- Misses       2053     2157     +104     
Impacted Files Coverage Δ
snuba/settings/settings_distributed.py 100.00% <ø> (ø)
snuba/clusters/storage_sets.py 100.00% <100.00%> (ø)
snuba/datasets/events_format.py 94.66% <100.00%> (ø)
snuba/migrations/groups.py 94.79% <100.00%> (+0.34%) ⬆️
...igrations/snuba_migrations/replays/0001_replays.py 100.00% <100.00%> (ø)
snuba/settings/__init__.py 94.59% <100.00%> (ø)
...nsactions_onpremise_fix_orderby_and_partitionby.py 32.00% <0.00%> (-52.00%) ⬇️
...ts/0010_groupedmessages_onpremise_compatibility.py 51.11% <0.00%> (-48.89%) ⬇️
tests/migrations/test_runner_individual.py 52.74% <0.00%> (-40.66%) ⬇️
...ns/snuba_migrations/events/0014_backfill_errors.py 92.72% <0.00%> (-3.64%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02dbd05...e4782d1. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unsupported type for timedelta days component in snuba-consumer
4 participants