Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update frontend packages #2802

Merged
merged 2 commits into from
Jun 13, 2022
Merged

Conversation

evanh
Copy link
Member

@evanh evanh commented Jun 13, 2022

This is a duplicate of a couple dependabot PRs. They were failing CI and it's
easier to debug CI problems on an internal PR vs. external.

Dependabot PRs:
#2779
#2790
#2804

This is a duplicate of a couple dependabot PRs. They were failing CI and it's
easier to debug CI problems on an internal PR vs. external.
@evanh evanh requested a review from a team as a code owner June 13, 2022 14:26
@lynnagara
Copy link
Member

lynnagara commented Jun 13, 2022

Is there a new js build to be checked in, or did bumping these not change the bundle at all?

@evanh
Copy link
Member Author

evanh commented Jun 13, 2022

did bumping these not change the bundle at all?

No change to the bundle, I made sure.

@codecov-commenter
Copy link

Codecov Report

Merging #2802 (4e5307e) into master (02dbd05) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2802      +/-   ##
==========================================
- Coverage   92.83%   92.77%   -0.06%     
==========================================
  Files         611      612       +1     
  Lines       28639    28662      +23     
==========================================
+ Hits        26586    26591       +5     
- Misses       2053     2071      +18     
Impacted Files Coverage Δ
snuba/settings/settings_distributed.py 0.00% <0.00%> (-100.00%) ⬇️
snuba/settings/settings_test_distributed.py 0.00% <0.00%> (-100.00%) ⬇️
...ts/0010_groupedmessages_onpremise_compatibility.py 95.55% <0.00%> (-4.45%) ⬇️
snuba/optimize.py 87.50% <0.00%> (-3.75%) ⬇️
snuba/migrations/table_engines.py 95.50% <0.00%> (-3.38%) ⬇️
...nsactions_onpremise_fix_orderby_and_partitionby.py 81.33% <0.00%> (-2.67%) ⬇️
tests/migrations/test_runner_individual.py 91.20% <0.00%> (-2.20%) ⬇️
snuba/clusters/cluster.py 94.92% <0.00%> (-1.45%) ⬇️
snuba/settings/__init__.py 94.59% <0.00%> (ø)
snuba/clusters/storage_sets.py 100.00% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02dbd05...4e5307e. Read the comment docs.

@evanh evanh merged commit 703f713 into master Jun 13, 2022
@evanh evanh deleted the evanh/fix/dependabot-updates-with-build branch June 13, 2022 18:53
JoshFerge pushed a commit that referenced this pull request Jun 13, 2022
This is a duplicate of a couple dependabot PRs. They were failing CI and it's
easier to debug CI problems on an internal PR vs. external.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants