Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Bump arroyo #2796

Merged
merged 5 commits into from
Jun 9, 2022
Merged

feat: Bump arroyo #2796

merged 5 commits into from
Jun 9, 2022

Conversation

lynnagara
Copy link
Member

Depends on #2792

We shouldn't ever manually pass a next_offset to Message. This is
because next_offset must always equal to offset + 1, and this will
be properly applied as long as we don't pass anything.

In a future version of Arroyo, the ability to pass this at all
will be removed.
@lynnagara lynnagara requested a review from a team as a code owner June 7, 2022 22:47
@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2022

Codecov Report

Merging #2796 (f47acbc) into master (587e9f9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2796   +/-   ##
=======================================
  Coverage   92.82%   92.82%           
=======================================
  Files         609      609           
  Lines       28604    28604           
=======================================
  Hits        26551    26551           
  Misses       2053     2053           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 587e9f9...f47acbc. Read the comment docs.

Base automatically changed from dont-pass-next-offset to master June 9, 2022 17:30
@lynnagara lynnagara merged commit 02dbd05 into master Jun 9, 2022
@lynnagara lynnagara deleted the bump-arroyo branch June 9, 2022 22:07
JoshFerge pushed a commit that referenced this pull request Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants