Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dlq): Metrics ignored messages should be Sentry Errors #2698

Merged
merged 2 commits into from
May 13, 2022

Conversation

rahul-kumar-saini
Copy link
Contributor

Overview

  • Metrics DLQ is behind a runtime config right now
  • Warns but should error if we encounter an invalid message and the DLQ is disabled

@rahul-kumar-saini rahul-kumar-saini requested a review from a team as a code owner May 13, 2022 20:12
@codecov-commenter
Copy link

codecov-commenter commented May 13, 2022

Codecov Report

Merging #2698 (35c512a) into master (c6f97e9) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #2698      +/-   ##
==========================================
- Coverage   92.75%   92.69%   -0.07%     
==========================================
  Files         613      613              
  Lines       29043    29043              
==========================================
- Hits        26938    26920      -18     
- Misses       2105     2123      +18     
Impacted Files Coverage Δ
snuba/datasets/metrics_bucket_processor.py 84.15% <0.00%> (ø)
snuba/settings/settings_distributed.py 0.00% <0.00%> (-100.00%) ⬇️
snuba/settings/settings_test_distributed.py 0.00% <0.00%> (-100.00%) ⬇️
...ts/0010_groupedmessages_onpremise_compatibility.py 95.55% <0.00%> (-4.45%) ⬇️
snuba/optimize.py 87.50% <0.00%> (-3.75%) ⬇️
snuba/migrations/table_engines.py 95.50% <0.00%> (-3.38%) ⬇️
...nsactions_onpremise_fix_orderby_and_partitionby.py 81.33% <0.00%> (-2.67%) ⬇️
tests/migrations/test_runner_individual.py 91.20% <0.00%> (-2.20%) ⬇️
snuba/clusters/cluster.py 94.61% <0.00%> (-1.54%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6f97e9...35c512a. Read the comment docs.

@rahul-kumar-saini rahul-kumar-saini enabled auto-merge (squash) May 13, 2022 20:31
@rahul-kumar-saini rahul-kumar-saini merged commit ca8c62d into master May 13, 2022
@rahul-kumar-saini rahul-kumar-saini deleted the fix/dlq-error-instead-of-warning branch May 13, 2022 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants