Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow arbitrary AppIDs #2692

Merged
merged 3 commits into from
May 13, 2022
Merged

fix: Allow arbitrary AppIDs #2692

merged 3 commits into from
May 13, 2022

Conversation

evanh
Copy link
Member

@evanh evanh commented May 12, 2022

This was originally written with the intention of having a registry of AppIDs
that could be used to check and validate incoming values. It's not clear if that
is still a strategy we want to use in the future, so for now allow arbitrary
values so we can start collecting some basic data.

This was originally written with the intention of having a registry of AppIDs
that could be used to check and validate incoming values. It's not clear if that
is still a strategy we want to use in the future, so for now allow arbitrary
values so we can start collecting some basic data.
@evanh evanh requested a review from a team as a code owner May 12, 2022 19:11
Copy link
Member

@nikhars nikhars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left minor comments. But I will approve.

snuba/attribution/__init__.py Outdated Show resolved Hide resolved
snuba/attribution/__init__.py Outdated Show resolved Hide resolved
@evanh evanh enabled auto-merge (squash) May 13, 2022 20:26
@codecov-commenter
Copy link

codecov-commenter commented May 13, 2022

Codecov Report

Merging #2692 (510b29e) into master (c6f97e9) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2692      +/-   ##
==========================================
- Coverage   92.75%   92.74%   -0.01%     
==========================================
  Files         613      612       -1     
  Lines       29043    29026      -17     
==========================================
- Hits        26938    26920      -18     
- Misses       2105     2106       +1     
Impacted Files Coverage Δ
snuba/attribution/__init__.py 100.00% <100.00%> (ø)
snuba/attribution/appid.py 91.66% <100.00%> (-8.34%) ⬇️
tests/test_snql_api.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6f97e9...510b29e. Read the comment docs.

@evanh evanh merged commit 5051fb5 into master May 13, 2022
@evanh evanh deleted the evanh/fix/allow-arbitrary-app-ids branch May 13, 2022 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants