Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(subscriptions): Add config to skip stale subscriptions in executor #2676

Merged
merged 1 commit into from
May 6, 2022

Conversation

lynnagara
Copy link
Member

The CLI argument --stale-threshold-seconds can be overriden via config.

The CLI argument --stale-threshold-seconds can be overriden via config.
@lynnagara lynnagara requested a review from a team as a code owner May 6, 2022 12:15
@lynnagara lynnagara enabled auto-merge (squash) May 6, 2022 12:20
@codecov-commenter
Copy link

codecov-commenter commented May 6, 2022

Codecov Report

Merging #2676 (889b0e4) into master (db0931f) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #2676      +/-   ##
==========================================
- Coverage   92.86%   92.86%   -0.01%     
==========================================
  Files         606      606              
  Lines       28651    28652       +1     
==========================================
  Hits        26608    26608              
- Misses       2043     2044       +1     
Impacted Files Coverage Δ
snuba/cli/subscriptions_executor.py 53.70% <0.00%> (-1.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db0931f...889b0e4. Read the comment docs.

@lynnagara lynnagara merged commit 4efc98d into master May 6, 2022
@lynnagara lynnagara deleted the skip-stale-config branch May 6, 2022 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants