Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tiger writes): Disable ignore write errors #2598

Merged
merged 3 commits into from
Apr 12, 2022
Merged

Conversation

nikhars
Copy link
Member

@nikhars nikhars commented Apr 11, 2022

Now that we have been running inserts on the tiger cluster without
any issues for more than a month, its safe to not ignore the write
errors anymore for the consumers.

Now that we have been running inserts on the tiger cluster without
any issues for more than a month, its safe to not ignore the write
errors anymore for the consumers.
@nikhars nikhars requested a review from a team as a code owner April 11, 2022 18:30
@codecov-commenter
Copy link

codecov-commenter commented Apr 11, 2022

Codecov Report

Merging #2598 (48699dd) into master (02a56a8) will decrease coverage by 0.12%.
The diff coverage is 100.00%.

❗ Current head 48699dd differs from pull request most recent head bc314e4. Consider uploading reports for the commit bc314e4 to get more accurate results

@@            Coverage Diff             @@
##           master    #2598      +/-   ##
==========================================
- Coverage   92.92%   92.79%   -0.13%     
==========================================
  Files         606      606              
  Lines       28126    28127       +1     
==========================================
- Hits        26135    26101      -34     
- Misses       1991     2026      +35     
Impacted Files Coverage Δ
snuba/datasets/storages/errors_v2.py 100.00% <ø> (ø)
snuba/datasets/storages/transactions_v2.py 100.00% <ø> (ø)
tests/test_consumer.py 84.45% <100.00%> (-15.55%) ⬇️
snuba/consumers/consumer.py 86.18% <0.00%> (-3.32%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02a56a8...bc314e4. Read the comment docs.

@nikhars nikhars enabled auto-merge (squash) April 12, 2022 17:17
@nikhars nikhars merged commit 7692d2d into master Apr 12, 2022
@nikhars nikhars deleted the fix/tiger-writes branch April 12, 2022 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants