Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(subscription-verifier): Totals is not always present in result #2594

Merged
merged 1 commit into from
Apr 11, 2022

Conversation

lynnagara
Copy link
Member

Not all subscriptions have "totals". Previously the verifier would
crash when it encountered a subscription without this key.

Not all subscriptions have "totals". Previously the verifier would
crash when it encountered a subscription without this key.
@lynnagara lynnagara requested a review from a team as a code owner April 10, 2022 23:45
@codecov-commenter
Copy link

codecov-commenter commented Apr 10, 2022

Codecov Report

Merging #2594 (fce669e) into master (4c356b3) will not change coverage.
The diff coverage is n/a.

❗ Current head fce669e differs from pull request most recent head 929824a. Consider uploading reports for the commit 929824a to get more accurate results

@@           Coverage Diff           @@
##           master    #2594   +/-   ##
=======================================
  Coverage   92.92%   92.92%           
=======================================
  Files         606      606           
  Lines       28126    28126           
=======================================
  Hits        26135    26135           
  Misses       1991     1991           
Impacted Files Coverage Δ
snuba/subscriptions/verifier.py 76.13% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c356b3...929824a. Read the comment docs.

@lynnagara lynnagara enabled auto-merge (squash) April 10, 2022 23:55
@lynnagara lynnagara merged commit 02a56a8 into master Apr 11, 2022
@lynnagara lynnagara deleted the fix-verifier branch April 11, 2022 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants