fix(metrics): Remove bucket storages from devserver #2591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onewland
approved these changes
Apr 8, 2022
onewland
reviewed
Apr 8, 2022
| @@ -144,9 +144,6 @@ def devserver(*, bootstrap: bool, workers: bool) -> None: | |||
| [ | |||
| "snuba", | |||
| "multistorage-consumer", | |||
There was a problem hiding this comment.
let's change this to be just consumer (there is only one storage) like in Meredith's PR in #2588
There was a problem hiding this comment.
Whoops sorry, pressed merge a second too early.
There was a problem hiding this comment.
no problem, you had the ship it already
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #2579:
snuba devserverrecently failed to start with the following error message:This PR fixes the error by removing remaining traces of
metrics_*buckets.