Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert accidental push to master, disallow this from happening again #2336

Merged
merged 4 commits into from
Jan 11, 2022

Conversation

volokluev
Copy link
Member

@volokluev volokluev commented Jan 11, 2022

I added a test utility thinking it was on its own branch, it was not, I pushed out of muscle memory and nothing stopped me.

Now there is a pre-commit hook assuring you cannot commit onto master.

@volokluev volokluev requested a review from a team as a code owner January 11, 2022 18:37
@codecov-commenter
Copy link

Codecov Report

Merging #2336 (e8ccf33) into master (4631aea) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2336      +/-   ##
==========================================
+ Coverage   92.66%   92.75%   +0.08%     
==========================================
  Files         560      559       -1     
  Lines       25818    25735      -83     
==========================================
- Hits        23924    23870      -54     
+ Misses       1894     1865      -29     
Impacted Files Coverage Δ
tests/query/test_expressions.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4631aea...e8ccf33. Read the comment docs.

@volokluev volokluev enabled auto-merge (squash) January 11, 2022 19:43
@volokluev volokluev merged commit 673e346 into master Jan 11, 2022
@volokluev volokluev deleted the vlad/revert_push branch January 11, 2022 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants