Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ops): add transactions_ro storage support #2331

Merged
merged 14 commits into from
Jan 11, 2022

Conversation

onewland
Copy link
Contributor

@onewland onewland commented Jan 7, 2022

Add a read-only mode to transactions via a new transactions_ro storage.

It should be settable via a global flag or by a referrer list in snuba.settings.

https://getsentry.atlassian.net/browse/SNS-990

@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2022

Codecov Report

Merging #2331 (03c98f3) into master (e41efa4) will decrease coverage by 0.13%.
The diff coverage is 79.13%.

❗ Current head 03c98f3 differs from pull request most recent head e79390e. Consider uploading reports for the commit e79390e to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2331      +/-   ##
==========================================
- Coverage   92.75%   92.61%   -0.14%     
==========================================
  Files         559      562       +3     
  Lines       25736    25871     +135     
==========================================
+ Hits        23871    23960      +89     
- Misses       1865     1911      +46     
Impacted Files Coverage Δ
snuba/clusters/cluster.py 93.10% <ø> (-1.77%) ⬇️
snuba/settings/settings_distributed.py 0.00% <ø> (-100.00%) ⬇️
snuba/settings/validation.py 65.51% <ø> (ø)
tests/clusters/test_cluster.py 100.00% <ø> (ø)
tests/utils/as_code_formatter.py 62.82% <62.82%> (ø)
snuba/clusters/storage_sets.py 100.00% <100.00%> (ø)
snuba/datasets/entities/transactions.py 100.00% <100.00%> (ø)
snuba/datasets/storages/__init__.py 100.00% <100.00%> (ø)
snuba/datasets/storages/factory.py 100.00% <100.00%> (ø)
snuba/datasets/storages/transactions.py 100.00% <100.00%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e41efa4...e79390e. Read the comment docs.

@onewland onewland changed the title add transactions_ro storage support with global config flag add transactions_ro storage support Jan 7, 2022
@onewland onewland changed the title add transactions_ro storage support feat(ops): add transactions_ro storage support Jan 7, 2022
@onewland onewland marked this pull request as ready for review January 7, 2022 22:40
@onewland onewland requested a review from a team as a code owner January 7, 2022 22:40
Copy link
Contributor

@fpacifici fpacifici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the table name.
Now this must be merged after the change to the prod configuration to declare the storage set.

snuba/datasets/storages/transactions_ro.py Outdated Show resolved Hide resolved
Copy link
Contributor

@fpacifici fpacifici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks,
I guess #2334 goes first, right ? (or at the same time).

@onewland onewland enabled auto-merge (squash) January 11, 2022 19:08
@onewland onewland merged commit bafee3a into master Jan 11, 2022
@onewland onewland deleted the readonly-transaction-storage branch January 11, 2022 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants