-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ops): add transactions_ro storage support #2331
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2331 +/- ##
==========================================
- Coverage 92.75% 92.61% -0.14%
==========================================
Files 559 562 +3
Lines 25736 25871 +135
==========================================
+ Hits 23871 23960 +89
- Misses 1865 1911 +46
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the table name.
Now this must be merged after the change to the prod configuration to declare the storage set.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks,
I guess #2334 goes first, right ? (or at the same time).
451b995
to
e79390e
Compare
Add a read-only mode to transactions via a new
transactions_ro
storage.It should be settable via a global flag or by a referrer list in
snuba.settings
.https://getsentry.atlassian.net/browse/SNS-990