fix(arm64) Fix tests so they work on arm64 as well #2329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is mostly fixing a bug with our current tests, where in the old version of Clickhouse the events are not being merged before the tests run. In the new version of Clickhouse the events are merged before the tests, and since the fixtures all use the same span_id, they are actually only sending one event.
Codecov Report
@@ Coverage Diff @@
## master #2329 +/- ##
==========================================
- Coverage 92.75% 92.68% -0.07%
==========================================
Files 558 558
Lines 25667 25668 +1
==========================================
- Hits 23807 23791 -16
- Misses 1860 1877 +17
Continue to review full report at Codecov.
|
onewland
approved these changes
Jan 3, 2022
| @@ -303,7 +304,7 @@ def test_column_formatting(self) -> None: | |||
| assert response.status_code == 200, response.data | |||
| assert len(data["data"]) == 1 | |||
| assert data["data"][0]["event_id"] == first_event_id | |||
| assert data["data"][0]["span_id"] == "8841662216cc598b" | |||
| assert data["data"][0]["span_id"] == "841662216cc598b1" | |||
There was a problem hiding this comment.
could we maybe extract this to a constant, to make it more straightforward if we want to update it again?
There was a problem hiding this comment.
Since the number actually changes (this happens to be the first) it's not possible to make it a true constant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly fixing a bug with our current tests, where in the old version of
Clickhouse the events are not being merged before the tests run. In the new
version of Clickhouse the events are merged before the tests, and since the
fixtures all use the same span_id, they are actually only sending one event.