feat(freight): Deploy subscriptions executor with Freight #2322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just noticed that ffad626 didn't get deployed since we never actually added the executor here.
nikhars
approved these changes
Dec 21, 2021
Codecov Report
@@ Coverage Diff @@
## master #2322 +/- ##
=======================================
Coverage 92.78% 92.78%
=======================================
Files 558 558
Lines 25649 25649
=======================================
Hits 23799 23799
Misses 1850 1850 Continue to review full report at Codecov.
|
lynnagara
added a commit
that referenced
this pull request
Dec 22, 2021
)" This reverts commit 8a9410e. This commit caused the freight deployment to fail. Need to investigate before including this in the deployment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just noticed that ffad626
didn't get deployed since we never actually added the executor here.