Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(admin): Allow % in extra part of system query #2320

Merged
merged 2 commits into from
Dec 21, 2021

Conversation

lynnagara
Copy link
Member

Support queries like 'WHERE some_column LIKE '%something%'

Support queries like 'WHERE some_column LIKE '%something%'
@lynnagara lynnagara requested a review from a team as a code owner December 21, 2021 20:41
@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2021

Codecov Report

Merging #2320 (74faa11) into master (4483262) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2320   +/-   ##
=======================================
  Coverage   92.79%   92.79%           
=======================================
  Files         558      558           
  Lines       25642    25642           
=======================================
  Hits        23794    23794           
  Misses       1848     1848           
Impacted Files Coverage Δ
snuba/admin/clickhouse/system_queries.py 68.81% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4483262...74faa11. Read the comment docs.

@lynnagara lynnagara merged commit 35f4ea1 into master Dec 21, 2021
@lynnagara lynnagara deleted the support-percent-in-extra branch December 21, 2021 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants