Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Commit offsets on subscription executor if sample rate is set to 0 #2317

Merged
merged 3 commits into from
Dec 21, 2021

Conversation

lynnagara
Copy link
Member

@lynnagara lynnagara commented Dec 20, 2021

Currently if the executor sample rate is set to 0 we don't send any events
through the processing strategy or commit any offsets. In our dashboards
the lag grows continuously dwarfing all other topics/consumer groups.

This adds a temporary workaround that just always commits offsets for every
message if the sampling rate is 0. We can remove it once we actually start
processing executor messages.

Currently if the executor sample rate is set to 0 we don't send any events
through the processing strategy or commit any offsetes. In our dashboards
the lag grows continuously dwarfing all other topics/consumer groups.

This adds a temporary workaround that just always commits offsets for every
message if the sampling rate is 0. We can remove it once we actually start
processing executor messages.
@lynnagara lynnagara requested a review from a team as a code owner December 20, 2021 23:47
@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2021

Codecov Report

Merging #2317 (c9c149a) into master (f06185a) will increase coverage by 0.05%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2317      +/-   ##
==========================================
+ Coverage   92.72%   92.78%   +0.05%     
==========================================
  Files         558      558              
  Lines       25645    25649       +4     
==========================================
+ Hits        23780    23799      +19     
+ Misses       1865     1850      -15     
Impacted Files Coverage Δ
snuba/subscriptions/executor_consumer.py 83.63% <50.00%> (-0.84%) ⬇️
snuba/clusters/cluster.py 94.87% <0.00%> (+1.70%) ⬆️
tests/migrations/test_runner_individual.py 100.00% <0.00%> (+1.76%) ⬆️
snuba/migrations/table_engines.py 98.76% <0.00%> (+2.46%) ⬆️
...nsactions_onpremise_fix_orderby_and_partitionby.py 84.00% <0.00%> (+2.66%) ⬆️
...ts/0010_groupedmessages_onpremise_compatibility.py 100.00% <0.00%> (+4.44%) ⬆️
snuba/optimize.py 90.69% <0.00%> (+6.97%) ⬆️
snuba/settings/settings_distributed.py 100.00% <0.00%> (+100.00%) ⬆️
snuba/settings/settings_test_distributed.py 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f06185a...c9c149a. Read the comment docs.

@lynnagara lynnagara merged commit ffad626 into master Dec 21, 2021
@lynnagara lynnagara deleted the executor-commit-offsets branch December 21, 2021 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants