fix: Prevent all subscriptions from being logged as non-matching #2315
Conversation
We added "profile" to the ClickHouse result which contains information about the query execution that will never actually be the same. Strip this key before diffing the two queries.
| if "profile" in result_copy: | ||
| del result_copy["profile"] |
There was a problem hiding this comment.
this seems the wrong way to go about this. We're massaging the return payload so we can == it. Why not just write the comparison function to do what we want and keep the return payload the same?
There was a problem hiding this comment.
This is what we are doing. We are making a copy of result - not modifying the original. The variable called result_copy gets thrown away. Since this is fairly specific just to diffing for subscriptions logging I didn't want to change __eq__ on the actual Result object.
lynnagara
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2315 +/- ##
=======================================
Coverage 92.79% 92.79%
=======================================
Files 558 558
Lines 25642 25645 +3
=======================================
+ Hits 23794 23797 +3
Misses 1848 1848
Continue to review full report at Codecov.
|
We added "profile" to the ClickHouse result which contains information
about the query execution that will never actually be the same. Strip this
key before diffing the two queries and logging discrepancies to Sentry.