Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(admin): Replace nested table with raw JSON and copy to clipboard button #2310

Merged
merged 1 commit into from
Dec 17, 2021
Merged

feat(admin): Replace nested table with raw JSON and copy to clipboard button #2310

merged 1 commit into from
Dec 17, 2021

Conversation

lynnagara
Copy link
Member

This is what the UI looks like after this change

Screen Shot 2021-12-17 at 3 14 17 pm

@lynnagara lynnagara requested a review from a team as a code owner December 17, 2021 23:15
@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2021 •
edited
Loading

Codecov Report

Merging #2310 (e29616f) into master (e5bf42b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2310   +/-   ##
=======================================
  Coverage   92.78%   92.78%           
=======================================
  Files         557      557           
  Lines       25611    25611           
=======================================
  Hits        23763    23763           
  Misses       1848     1848

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5bf42b...e29616f. Read the comment docs.

onewland
onewland approved these changes Dec 17, 2021
View reviewed changes
Copy link
Contributor

@onewland onewland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice if the JSON was indented/highlighted but not that important since there's a quick copy/paste

@lynnagara lynnagara merged commit fd1576d into master Dec 17, 2021
@lynnagara lynnagara deleted the clickhouse-admin-ui branch December 17, 2021 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onewland onewland onewland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lynnagara @codecov-commenter @onewland