Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(admin): validate by node list in query admin tool #2307

Merged
merged 2 commits into from
Dec 17, 2021

Conversation

onewland
Copy link
Contributor

Rather than enforce using the main query node, validate by the list of nodes in the ClickHouse cluster

@onewland onewland requested a review from a team as a code owner December 17, 2021 19:06
@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2021

Codecov Report

Merging #2307 (0b6f010) into master (0ae26a5) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2307   +/-   ##
=======================================
  Coverage   92.83%   92.83%           
=======================================
  Files         557      557           
  Lines       25551    25551           
=======================================
  Hits        23720    23720           
  Misses       1831     1831           
Impacted Files Coverage Δ
snuba/admin/clickhouse/system_queries.py 68.81% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ae26a5...0b6f010. Read the comment docs.

@onewland onewland merged commit 07c8256 into master Dec 17, 2021
@onewland onewland deleted the validate-by-node-list branch December 17, 2021 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants