Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(subscriptions): Update command args to accept metrics entities #2302

Merged
merged 4 commits into from
Jan 13, 2022

Conversation

ahmedetefy
Copy link
Contributor

Adds to the subscriptions_executor and subscriptions_scheduler
commands the supported metrics entity choices

Adds to the subscriptions_executor and subscriptions_scheduler
commands the supported metrics entity choices
@ahmedetefy ahmedetefy requested a review from a team as a code owner December 17, 2021 11:20
@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2021

Codecov Report

Merging #2302 (0c056a1) into master (6f92898) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2302   +/-   ##
=======================================
  Coverage   92.97%   92.97%           
=======================================
  Files         563      563           
  Lines       25932    25932           
=======================================
  Hits        24109    24109           
  Misses       1823     1823           
Impacted Files Coverage Δ
snuba/cli/subscriptions_executor.py 53.48% <ø> (ø)
snuba/cli/subscriptions_scheduler.py 57.77% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f92898...0c056a1. Read the comment docs.

@lynnagara
Copy link
Member

lynnagara commented Dec 17, 2021

@ahmedetefy This is not really ready for use yet, do you need these for a particular reason? Or just making sure these options are eventually available?

@ahmedetefy
Copy link
Contributor Author

@lynnagara
Yep, just making sure these options are available eventually.

@ahmedetefy ahmedetefy merged commit 330765c into master Jan 13, 2022
@ahmedetefy ahmedetefy deleted the cra-metrics/add-metrics-subscriptions-infra branch January 13, 2022 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants