feat(admin) Add authorization provider in snuba admin #2301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2301 +/- ##
==========================================
- Coverage 92.75% 92.74% -0.01%
==========================================
Files 558 559 +1
Lines 25668 25694 +26
==========================================
+ Hits 23808 23831 +23
- Misses 1860 1863 +3
Continue to review full report at Codecov.
|
evanh
approved these changes
Dec 17, 2021
lynnagara
reviewed
Dec 17, 2021
snuba/admin/auth.py
Outdated
| # TODO: provide a more structured representation of the User that | ||
| # includes the role at least. | ||
| def authorize_request() -> str: | ||
| provider_id = state.settings.ADMIN_AUTH_PROVIDER |
There was a problem hiding this comment.
Don't think you need to go through state module for this
Suggested change
| provider_id = state.settings.ADMIN_AUTH_PROVIDER | |
| provider_id = snuba.settings.ADMIN_AUTH_PROVIDER |
There was a problem hiding this comment.
right I changed it from runtime config to settings sand forgot to fix that
lynnagara
approved these changes
Dec 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The admin relies on a proxy to perform authentication and authorization.
This is not great for two reasons:
This adds an abstraction to performa authorization before each server request on the admin UI.
This abstraction has multiple implementations for multiple authorization providers. The default is NOOP and allows everything through. The next to be implemented is IAP, then we can add one for basic HTTP auth useful on prem.