feat(admin): Add ability to edit existing runtime config #2297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now editing is only possible if the current and new types are the same. It does not currently support passing the "force" option which is required if the evaluated type is not the same as before.
Codecov Report
@@ Coverage Diff @@
## master #2297 +/- ##
==========================================
- Coverage 92.93% 92.87% -0.06%
==========================================
Files 556 556
Lines 25494 25511 +17
==========================================
+ Hits 23692 23693 +1
- Misses 1802 1818 +16
Continue to review full report at Codecov.
|
evanh
approved these changes
Dec 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now editing is only possible if the current and new types
are the same. It does not currently support passing the "force"
option which is required if the evaluated type is not the same as before.
UI demo:
https://user-images.githubusercontent.com/1779792/146467423-46f1d2e1-a35c-490e-817f-6f31131e2d8c.mov