Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(subscriptions): Ensure producer is closed on SIGINT and SIGTERM #2289

Merged
merged 5 commits into from
Dec 16, 2021

Conversation

lynnagara
Copy link
Member

No description provided.

@lynnagara lynnagara requested a review from a team as a code owner December 16, 2021 01:19
@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2021

Codecov Report

Merging #2289 (27423b1) into master (bb441ad) will increase coverage by 0.06%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2289      +/-   ##
==========================================
+ Coverage   92.92%   92.98%   +0.06%     
==========================================
  Files         556      556              
  Lines       25429    25431       +2     
==========================================
+ Hits        23630    23648      +18     
+ Misses       1799     1783      -16     
Impacted Files Coverage Δ
snuba/cli/subscriptions_scheduler.py 57.77% <33.33%> (-0.37%) ⬇️
snuba/clusters/cluster.py 94.87% <0.00%> (+1.70%) ⬆️
tests/migrations/test_runner_individual.py 100.00% <0.00%> (+1.76%) ⬆️
snuba/migrations/table_engines.py 98.76% <0.00%> (+2.46%) ⬆️
...nsactions_onpremise_fix_orderby_and_partitionby.py 84.00% <0.00%> (+2.66%) ⬆️
...ts/0010_groupedmessages_onpremise_compatibility.py 100.00% <0.00%> (+4.44%) ⬆️
snuba/optimize.py 90.69% <0.00%> (+6.97%) ⬆️
snuba/settings/settings_distributed.py 100.00% <0.00%> (+100.00%) ⬆️
snuba/settings/settings_test_distributed.py 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb441ad...27423b1. Read the comment docs.

@lynnagara lynnagara merged commit 34075e8 into master Dec 16, 2021
@lynnagara lynnagara deleted the close-scheduler-producer branch December 16, 2021 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants