Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(admin): Runtime config notifications take two #2285

Merged
merged 7 commits into from
Dec 15, 2021

Conversation

lynnagara
Copy link
Member

This PR mostly brings back @MeredithAnya changes from #2185 and cbef1ec

I've adjusted some types and integrated the logging notifier into the create new config API.

@lynnagara lynnagara requested a review from a team as a code owner December 15, 2021 19:25
Copy link
Member

@MeredithAnya MeredithAnya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, thanks for adding those types

@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2021

Codecov Report

Merging #2285 (0b2a742) into master (b9f0471) will decrease coverage by 0.12%.
The diff coverage is 58.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2285      +/-   ##
==========================================
- Coverage   93.06%   92.94%   -0.13%     
==========================================
  Files         553      556       +3     
  Lines       25239    25329      +90     
==========================================
+ Hits        23488    23541      +53     
- Misses       1751     1788      +37     
Impacted Files Coverage Δ
snuba/admin/notifications/slack/utils.py 25.00% <25.00%> (ø)
snuba/admin/notifications/slack/client.py 41.17% <41.17%> (ø)
snuba/admin/notifications/base.py 75.51% <75.51%> (ø)
snuba/admin/views.py 65.67% <100.00%> (+2.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9f0471...0b2a742. Read the comment docs.

@lynnagara lynnagara merged commit b43eb18 into master Dec 15, 2021
@lynnagara lynnagara deleted the runtime-config-notification-take-two branch December 15, 2021 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants