Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Subscription executor has --override-result-topic option #2281

Merged
merged 3 commits into from
Dec 15, 2021

Conversation

lynnagara
Copy link
Member

Add an --override-result-topic option to the subscription executor.
Currently this is not wired up to anything but it will support
temporarily routing the produced subscription results to a different
topic so that the executor can be safely tested without affecting actual
users in production. The option should be removed once we are done testing.

Add an --override-result-topic option to the subscription executor.
Currently this is not wired up to anything but it will support
temporariliy routing the produced subscription results to a different
topic so that the executor can be safely tested without affecting actual
users in production. The option should be removed once we are done testing.
@lynnagara lynnagara requested a review from a team as a code owner December 14, 2021 21:21
@codecov-commenter
Copy link

Codecov Report

Merging #2281 (578afe6) into master (2a22e70) will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2281      +/-   ##
==========================================
+ Coverage   93.08%   93.20%   +0.11%     
==========================================
  Files         550      551       +1     
  Lines       24927    24990      +63     
==========================================
+ Hits        23203    23291      +88     
+ Misses       1724     1699      -25     
Impacted Files Coverage Δ
snuba/cli/subscriptions_executor.py 64.28% <100.00%> (+1.32%) ⬆️
snuba/subscriptions/executor_consumer.py 88.98% <100.00%> (+0.59%) ⬆️
tests/subscriptions/test_executor_consumer.py 100.00% <100.00%> (ø)
tests/admin/test_api.py 100.00% <0.00%> (ø)
snuba/state/__init__.py 80.58% <0.00%> (+0.58%) ⬆️
snuba/admin/views.py 80.00% <0.00%> (+80.00%) ⬆️
snuba/admin/runtime_config/__init__.py 84.61% <0.00%> (+84.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de89c09...578afe6. Read the comment docs.

@lynnagara lynnagara merged commit 11d097a into master Dec 15, 2021
@lynnagara lynnagara deleted the override-executor-result-topic branch December 15, 2021 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants