Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(subscriptions): Increase load factor to 3 for subscriptions test #2271

Merged
merged 2 commits into from
Dec 15, 2021

Conversation

lynnagara
Copy link
Member

@lynnagara lynnagara commented Dec 13, 2021

Got some small improvements from #2268. Let's try pushing this to 3.

… test

The change to omit redundant information from the scheduled message (#2268)
had a fairly significant positive effect on CPU usage, let's try increasing the load factor to 3.
@lynnagara lynnagara requested a review from a team as a code owner December 13, 2021 18:13
@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2021

Codecov Report

Merging #2271 (cd005e4) into master (b88c2e1) will decrease coverage by 0.40%.
The diff coverage is 66.66%.

❗ Current head cd005e4 differs from pull request most recent head 507de14. Consider uploading reports for the commit 507de14 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2271      +/-   ##
==========================================
- Coverage   93.06%   92.65%   -0.41%     
==========================================
  Files         553      553              
  Lines       25238    25239       +1     
==========================================
- Hits        23487    23386     -101     
- Misses       1751     1853     +102     
Impacted Files Coverage Δ
setup.py 0.00% <0.00%> (ø)
snuba/admin/clickhouse/nodes.py 52.63% <ø> (ø)
snuba/subscriptions/executor_consumer.py 88.98% <ø> (ø)
snuba/cli/subscriptions_executor.py 64.28% <100.00%> (+1.32%) ⬆️
snuba/settings/__init__.py 93.61% <100.00%> (ø)
...nsactions_onpremise_fix_orderby_and_partitionby.py 32.00% <0.00%> (-52.00%) ⬇️
...ts/0010_groupedmessages_onpremise_compatibility.py 51.11% <0.00%> (-48.89%) ⬇️
tests/migrations/test_runner_individual.py 68.14% <0.00%> (-31.86%) ⬇️
...ns/snuba_migrations/events/0014_backfill_errors.py 92.59% <0.00%> (-3.71%) ⬇️
snuba/migrations/table_engines.py 96.29% <0.00%> (-2.47%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11d097a...507de14. Read the comment docs.

@lynnagara lynnagara marked this pull request as draft December 13, 2021 20:38
@lynnagara lynnagara marked this pull request as ready for review December 14, 2021 21:09
@lynnagara lynnagara merged commit 6146063 into master Dec 15, 2021
@lynnagara lynnagara deleted the increase-load-test branch December 15, 2021 19:46
lynnagara added a commit that referenced this pull request Dec 15, 2021
…ons load test (#2271)"

This reverts commit 6146063.

Scheduler can't keep up with load_factor = 3, revert back to 2
lynnagara added a commit that referenced this pull request Dec 15, 2021
…ons load test (#2271)" (#2286)

This reverts commit 6146063.

Scheduler can't keep up with load_factor = 3, revert back to 2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants