code

getsentry · Aug 8, 2024 · 03a3fc7 · 03a3fc7
1 parent 8dec882
commit 03a3fc7
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/snuba/query/allocation_policies/bytes_scanned_rejecting_policy.py b/snuba/query/allocation_policies/bytes_scanned_rejecting_policy.py
@@ -45,7 +45,7 @@
 PETABYTE = 10**12
 DEFAULT_BYTES_SCANNED_LIMIT = int(1.28 * PETABYTE)
 DEFAULT_TIMEOUT_PENALIZATION = DEFAULT_BYTES_SCANNED_LIMIT // 40
-DEFAULT_BYTES_THROTTLE_DIVIDER = 2
+DEFAULT_BYTES_THROTTLE_DIVIDER = 1.5
 DEFAULT_THREADS_THROTTLE_DIVIDER = 2
 QUOTA_UNIT = "bytes"
 SUGGESTION = "The feature, organization/project is scanning too many bytes, this usually means they are abusing that API"
@@ -102,14 +102,14 @@ def _additional_config_definitions(self) -> list[AllocationPolicyConfig]:
             AllocationPolicyConfig(
                 "bytes_throttle_divider",
                 "Divide the scan limit by this number gives the throttling threshold",
-                int,
+                float,
                 DEFAULT_BYTES_THROTTLE_DIVIDER,
             ),
             AllocationPolicyConfig(
                 "threads_throttle_divider",
                 "max threads divided by this number is the number of threads we use to execute queries for a throttled (project_id|organization_id, referrer)",
                 int,
-                DEFAULT_BYTES_THROTTLE_DIVIDER,
+                DEFAULT_THREADS_THROTTLE_DIVIDER,
             ),
         ]
 

diff --git a/snuba/query/allocation_policies/per_referrer.py b/snuba/query/allocation_policies/per_referrer.py
@@ -23,7 +23,7 @@
 _DEFAULT_CONCURRENT_REQUEST_PER_REFERRER = 100
 _REFERRER_CONCURRENT_OVERRIDE = -1
 _REFERRER_MAX_THREADS_OVERRIDE = -1
-_REQUESTS_THROTTLE_DIVIDER = 2
+_REQUESTS_THROTTLE_DIVIDER = 1.5
 _THREADS_THROTTLE_DIVIDER = 2
 
 QUOTA_UNIT = "concurrent_queries"
@@ -77,7 +77,7 @@ def _additional_config_definitions(self) -> list[AllocationPolicyConfig]:
             AllocationPolicyConfig(
                 name="requests_throttle_divider",
                 description="default_concurrent_request_per_referrer divided by this value will be the threshold at which we will decrease the number of threads (THROTTLED_THREADS) used to execute queries",
-                value_type=int,
+                value_type=float,
                 default=_REQUESTS_THROTTLE_DIVIDER,
             ),
             AllocationPolicyConfig(