Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat(aci): use Action & Group for Slack Issue Alert Threads #84821

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

iamrajjoshi
Copy link
Member

this pr uses the new threads repo i have created and saves/fetches messages based action and group id. it is FF'ed behind the NOA flag.

Note: Links will still be broken in this implementation. this is considered in my spec and i have a later milestone that will fix that once the new UI is in place.

@iamrajjoshi iamrajjoshi requested a review from a team February 7, 2025 22:30
@iamrajjoshi iamrajjoshi self-assigned this Feb 7, 2025
@iamrajjoshi iamrajjoshi requested review from a team as code owners February 7, 2025 22:30
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Feb 7, 2025
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 81.69014% with 26 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../sentry/integrations/slack/actions/notification.py 64.38% 26 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master   #84821    +/-   ##
========================================
  Coverage   87.55%   87.56%            
========================================
  Files        9661     9666     +5     
  Lines      546963   547244   +281     
  Branches    21566    21566            
========================================
+ Hits       478920   479178   +258     
- Misses      67705    67728    +23     
  Partials      338      338            

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant